Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add withdrawals details to eth_getBlock methods #4808

Closed
jframe opened this issue Dec 12, 2022 · 3 comments · Fixed by #5146
Closed

Add withdrawals details to eth_getBlock methods #4808

jframe opened this issue Dec 12, 2022 · 3 comments · Fixed by #5146
Assignees
@siladu @wcgcyx
Labels
EIP Ethereum Improvement Proposal mainnet TeamGroot GH issues worked on by Groot Team

Comments

@jframe
Copy link
Contributor

jframe commented Dec 12, 2022 •
edited by siladu
Loading

Return withdrawals details from the eth_getBlock methods when withdrawals are enabled.

ethereum/execution-apis#334

Should probably also add to debug_getBadBlock - are there other debug/trace methods that might need withdrawals as well?

Acceptance Criteria

  • When withdrawals are enabled return the withdrawalsRoot and withdrawals in the returned block
  • Do not include the withdrawalsRoot or withdrawals when withdrawals are not enabled
@jframe jframe added TeamGroot GH issues worked on by Groot Team mainnet labels Dec 12, 2022
@jframe jframe mentioned this issue Dec 12, 2022
Closed
27 tasks
@siladu
Copy link
Contributor

siladu commented Dec 21, 2022

Implemented a quick and dirty solution for the testnet 161b70c

@siladu
Copy link
Contributor

siladu commented Jan 6, 2023

Consider reviewing and updating all of the APIs that return a Block e.g. debug_*

@siladu siladu mentioned this issue Jan 20, 2023
Merged
@non-fungible-nelson
Copy link
Contributor

Pending integration tests @siladu

@non-fungible-nelson non-fungible-nelson added the EIP Ethereum Improvement Proposal label Jan 27, 2023
@siladu siladu mentioned this issue Mar 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@siladu siladu

@wcgcyx wcgcyx

Labels
EIP Ethereum Improvement Proposal mainnet TeamGroot GH issues worked on by Groot Team
Projects
None yet
Milestone
No milestone
4 participants
@jframe @siladu @wcgcyx @non-fungible-nelson