Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculate blockValue for engine_getPayloadV2 #4861

Closed
siladu opened this issue Dec 22, 2022 · 2 comments · Fixed by #4883
Closed

Calculate blockValue for engine_getPayloadV2 #4861

siladu opened this issue Dec 22, 2022 · 2 comments · Fixed by #4883
Assignees
@wcgcyx
Labels
EIP Ethereum Improvement Proposal mainnet TeamGroot GH issues worked on by Groot Team TeamRevenant GH issues worked on by Revenant Team

Comments

@siladu
Copy link
Contributor

siladu commented Dec 22, 2022

blockValue stub of 0 was created in #4833

Now need to calculate the blockValue, which is still being discussed on ethereum/execution-apis#307
@siladu siladu added mainnet TeamGroot GH issues worked on by Groot Team TeamRevenant GH issues worked on by Revenant Team labels Dec 22, 2022
@siladu siladu mentioned this issue Dec 22, 2022
Closed
27 tasks
@wcgcyx
Copy link
Contributor

wcgcyx commented Jan 4, 2023

Looks like this should be implemented as part of the shanghai spec: https://github.com/ethereum/execution-apis/blob/main/src/engine/shanghai.md#specification-2

@wcgcyx wcgcyx mentioned this issue Jan 5, 2023
Merged
2 tasks
@wcgcyx
Copy link
Contributor

wcgcyx commented Jan 5, 2023

Draft PR: #4883

@non-fungible-nelson non-fungible-nelson added the EIP Ethereum Improvement Proposal label Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wcgcyx wcgcyx

Labels
EIP Ethereum Improvement Proposal mainnet TeamGroot GH issues worked on by Groot Team TeamRevenant GH issues worked on by Revenant Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Calculate block value wcgcyx/besu
3 participants
@siladu @wcgcyx @non-fungible-nelson