Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block value calculation may be incorrect in getPayloadV2 #5040

Closed
siladu opened this issue Feb 2, 2023 · 0 comments · Fixed by #5100
Closed

Block value calculation may be incorrect in getPayloadV2 #5040

siladu opened this issue Feb 2, 2023 · 0 comments · Fixed by #5100
Assignees
Labels
bug Something isn't working EIP Ethereum Improvement Proposal mainnet TeamGroot GH issues worked on by Groot Team

Comments

@siladu
Copy link
Contributor

siladu commented Feb 2, 2023

Some WIP hive tests have picked up an issue...

Besu is returning value, e.g. in one of the blocks, of 54089155500000000, but the expected value by the test (and returned by other clients) is 6224737500000000, which 8 times lower, and this is because, during the calculation, the "cumulative gas used" of the transaction is used to get the fee, instead of the "gas used"
If i swap the "gas used" by "cumulative gas used" while computing the expected value in the test, I get the exact same value as Besu

@siladu siladu added TeamGroot GH issues worked on by Groot Team mainnet EIP Ethereum Improvement Proposal labels Feb 2, 2023
@iamhsk iamhsk added the bug Something isn't working label Feb 6, 2023
@jframe jframe assigned jframe and unassigned jframe Feb 15, 2023
@siladu siladu mentioned this issue Feb 15, 2023
27 tasks
@gfukushima gfukushima self-assigned this Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working EIP Ethereum Improvement Proposal mainnet TeamGroot GH issues worked on by Groot Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants