Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't Record Bad Block When Proposing #5058

Closed
siladu opened this issue Feb 6, 2023 · 0 comments · Fixed by #5082
Closed

Don't Record Bad Block When Proposing #5058

siladu opened this issue Feb 6, 2023 · 0 comments · Fixed by #5082
Assignees
@gfukushima
Labels
mainnet TeamGroot GH issues worked on by Groot Team

Comments

@siladu
Copy link
Contributor

siladu commented Feb 6, 2023

Related to #5032

We build an invalid block, add it to bad blocks, then continue to build a valid block. It doesn't make sense to expose this internal transient error to an external API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gfukushima gfukushima

Labels
mainnet TeamGroot GH issues worked on by Groot Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop adding bad proposed block to bad block manager gfukushima/besu
2 participants
@siladu @gfukushima