Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky Test - NodeSmartContractPermissioningV2DNSAcceptanceTest.permissionedNodeShouldAddDnsRuleAndAllowNode #7191

Closed
siladu opened this issue Jun 7, 2024 · 1 comment · Fixed by #7256
Closed

Flaky Test - NodeSmartContractPermissioningV2DNSAcceptanceTest.permissionedNodeShouldAddDnsRuleAndAllowNode #7191

siladu opened this issue Jun 7, 2024 · 1 comment · Fixed by #7256
Labels
flake 60% of the time it works 100% of the time. permissioning account or node permissioning testing

Comments

@siladu
Copy link
Contributor

siladu commented Jun 7, 2024

Failed three times before passing: https://github.com/hyperledger/besu/actions/runs/9405880019/attempts/3

NodeSmartContractPermissioningV2DNSAcceptanceTest > permissionedNodeShouldAddDnsRuleAndAllowNode() FAILED
    org.opentest4j.AssertionFailedError: 
    Expecting value to be true but was false

Executed this locally without an issue

./gradlew acceptanceTestNotPrivacy --tests org.hyperledger.besu.tests.acceptance.permissioning.NodeSmartContractPermissioningV2DNSAcceptanceTest --tests org.hyperledger.besu.tests.acceptance.pubsub.NewPendingTransactionAcceptanceTest --tests org.hyperledger.besu.tests.acceptance.permissioning.AccountLocalAndOnchainPermissioningAcceptanceTest --tests org.hyperledger.besu.tests.acceptance.mining.MiningAcceptanceTest --tests org.hyperledger.besu.tests.acceptance.permissioning.AllowlistPersistorAcceptanceTest --tests org.hyperledger.besu.tests.acceptance.jsonrpc.DeployTransactionAcceptanceTest
@siladu siladu added testing flake 60% of the time it works 100% of the time. permissioning account or node permissioning labels Jun 7, 2024
@usmansaleem
Copy link
Member

Noticed on my PR as well. https://github.com/hyperledger/besu/actions/runs/9473929637/job/26103327843?pr=7200

@macfarla macfarla mentioned this issue Jun 25, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flake 60% of the time it works 100% of the time. permissioning account or node permissioning testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable Flaky tests - permissioning macfarla/besu
2 participants
@usmansaleem @siladu