Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameterize Consolidation Request contract address #7381

Closed
macfarla opened this issue Jul 26, 2024 · 1 comment · Fixed by #7647
Closed

Parameterize Consolidation Request contract address #7381

macfarla opened this issue Jul 26, 2024 · 1 comment · Fixed by #7647
Assignees
@gconnect
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@macfarla
Copy link
Contributor

Parameterize CONSOLIDATION_REQUEST_CONTRACT_ADDRESS on startup as the deposit request.

Context: Request made in this this comment of the System Call PR: #7263 (comment)

Probably used for devnets or any other network that has a different address for this contract.

Similar to depositContractAddress, which is in the genesis file.

Similar to #7288 for withdrawal request
@macfarla macfarla mentioned this issue Jul 26, 2024
Merged
7 tasks
@macfarla macfarla added enhancement New feature or request good first issue Good for newcomers labels Jul 26, 2024
@gconnect
Copy link
Contributor

gconnect commented Sep 10, 2024 •
edited
Loading

@macfarla please assign this issue to me

@gconnect gconnect mentioned this issue Sep 19, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gconnect gconnect

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add consolidationRequestContract in jsonGenesisConfig gconnect/besu
2 participants
@macfarla @gconnect