Implement new transaction replacement mechanism when adding transactions to the pool.

[AbdelStark]

Description

We should implement a new transaction replacement mechanism, similar to other client implementations.
Currently a new transaction (same user and same nonce) replaces an old one if the new gas price is higher than the old one. Other client implementations require the delta to be higher than a minimum percentage.
For instance this option is called pricebump in Geth implementation, configurable using --txpool.pricebump . This command line option is described as Price bump percentage to replace an already existing transaction and is defaulted to 10%.

Acceptance criteria

• New replacement mechanism is implemented
• Used for remote transactions received via P2P
• Used for local transactions received via eth_sendRawTransaction

Linked issues

• Invalid JSON RPC response: "" #559

[sambacha]

would the existing transaction replacement mechanism still be available for non-PoW Besu clients?

[AbdelStark]

would the existing transaction replacement mechanism still be available for non-PoW Besu clients?

Good question. Actually we have multiple options:

• Set the price bump to 0 by default, this would behave like the existing mechanism.
• Set the price bump to 10 by default to align with default behaviour of other mainnet clients, non-PoW Besu client would have to explicitly set it to 0 via CLI option.
• Set the default price bump depending on the consensus engine.

I will raise the point and see what other contributors think about it. Do you have a personal preference ?

[brianmcgee]

Setting a sane default based on the consensus engine would IMHO reduce the likelihood of any surprises for not much effort.

[AbdelStark]

Setting a sane default based on the consensus engine would IMHO reduce the likelihood of any surprises for not much effort.

@brianmcgee Thanks for the feedback.