-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intermittent Travis CI Issues #36
Comments
Example 1 |
Hopefully not as flaky as thought 😎
|
Clue: npm install and npm test both succeed on local ubuntu VM, but the missing dependency is highlighted as an issue there as well. Some code in a dependency might be importing different packages at runtime based on some criteria that differentiates between the Travis CI VM and the local VM I'm testing with: $ npm ls typedarray-to-buffer
@hyperledger-labs/[email protected] /REDACTED/blockchain-integration-framework
└─┬ [email protected]
└─┬ [email protected]
└─┬ [email protected]
└─┬ [email protected]
└─┬ [email protected] invalid (git://github.com/frozeman/WebSocket-Node.git#6c72925e3f8aaaea8dc8450f97627e85263999f2)
└── UNMET DEPENDENCY typedarray-to-buffer@^3.1.2
npm ERR! invalid: [email protected] /REDACTED/blockchain-integration-framework/node_modules/web3-providers-ws/node_modules/websocket
npm ERR! missing: typedarray-to-buffer@^3.1.2, required by [email protected] |
Tried upgrading web3 to latest stable but that has another issue that breaks dependencies ( Will try with web3 |
I tinkered with the travis build, had to update the web3 version from that beta release to a stable one and put in some shell code to ensure npm dependencies are installed in the example sub-projects as well (fabric/api, quorum/api) There is still the issue of flakiness which is a different one, it appears to be in one of the unit tests, but that doesn't always fail, just sometimes. For now I put the fixed up code here in a draft PR, will hopefully come up with something for the flaky unit test tomorrow: |
Web3 released a fix for the dependency issues in |
Also a list of other changes that were required to make the CI green: - clean up steps in the script: remove .git folder of websocket package - install npm dependencies in the fabric and quorum api folders - update web3 to 1.2.4 - update the post install patching of web3 formatter to match v1.2.4 - clean up: run "down" npm script for fabric and quorum - force volume re-creation when calling docker-compose up Also: the CI script is now in a separate .sh file so that it can be invoked locally on any dev machine that has the dependencies pre-installed Fixes #12 Fixes #36 Signed-off-by: Peter Somogyvari <[email protected]>
Also a list of other changes that were required to make the CI green: - clean up steps in the script: remove .git folder of websocket package - install npm dependencies in the fabric and quorum api folders - update web3 to 1.2.4 - update the post install patching of web3 formatter to match v1.2.4 - clean up: run "down" npm script for fabric and quorum - force volume re-creation when calling docker-compose up Also: the CI script is now in a separate .sh file so that it can be invoked locally on any dev machine that has the dependencies pre-installed Fixes hyperledger-cacti#12 Fixes hyperledger-cacti#36 Signed-off-by: Peter Somogyvari <[email protected]>
Investigate flaky Travis CI failures and determine if one or more fixes required
The text was updated successfully, but these errors were encountered: