build(ubiquity): remove ubiquity connector plugin #3142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafaelAPB
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna,
sandeepnRES and
outSH
as code owners
@RafaelAPB Yes, this is necessary to make CI pass |
petermetz
approved these changes
Mar 29, 2024
RafaelAPB
force-pushed
the
remove-ubiquity
branch
from
584c98f
to
a90af73
Compare
|
@outSH @petermetz updated. Good to go? :) |
Signed-off-by: Rafael Belchior <[email protected]>
RafaelAPB
force-pushed
the
remove-ubiquity
branch
from
a90af73
to
8dcdfca
Compare
petermetz
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
@RafaelAPB Sorry for missing the earlier question about the yarn.lock file!
Yes, you must commit the updated lock file otherwise the CI will not let it pass.
outSH
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Ubiquity package is not supported and it is breaking. Therefore, we shall remove it until support is provided.
Shall i also commit the updated yarn.lock?