[FABN-1056] update return type of sign() to Buffer

current EC CryptoSuite sign() returns DER encoded signature in array while the type definition for this is Buffer and the jsdoc for api.CryptoSuite.sign() is byte[]. This CR updates the return type of sign() to Buffer. Change-Id: Iea680c632b2465f552f3c7ae2181769bc6ce0572 Signed-off-by: zhaochy <[email protected]>
hyperledger · Dec 10, 2018 · cac1354 · cac1354
1 parent 3cb3fa7
commit cac1354
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/fabric-client/lib/impl/CryptoSuite_ECDSA_AES.js b/fabric-client/lib/impl/CryptoSuite_ECDSA_AES.js
@@ -235,7 +235,8 @@ class CryptoSuite_ECDSA_AES extends api.CryptoSuite {
 		let sig = this._ecdsa.sign(digest, signKey);
 		sig = _preventMalleability(sig, key._key.ecparams);
 		logger.debug('ecdsa signature: ', sig);
-		return sig.toDER();
+		const der = sig.toDER();
+		return Buffer.from(der);
 	}
 
 	verify(key, signature, digest) {