Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kura cache #4954

Closed
mversic opened this issue Aug 8, 2024 · 2 comments · Fixed by #5103
Closed

Kura cache #4954

mversic opened this issue Aug 8, 2024 · 2 comments · Fixed by #5103
Assignees

Comments

@mversic
Copy link
Contributor

mversic commented Aug 8, 2024

Do we need an implementation of cache in Kura? Can unbounded block_data cause an OOM? This can happen as the network grows, but also when restarting a peer when there was no snapshot

If we do make a block cache we should make sure that it's not susceptible to probing attacks from block_sync or simple FindBlocks query execution

@dima74
Copy link
Contributor

dima74 commented Sep 23, 2024

@mversic why do we need a cache? Can't we always keep the latest N blocks in memory and any older block always load from the disk when needed?

@mversic
Copy link
Contributor Author

mversic commented Sep 23, 2024

@mversic why do we need a cache? Can't we always keep the latest N blocks in memory and any older block always load from the disk when needed?

that's a cache with the policy to keep N latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants