Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(supervisor): failing tests, chores #5070

Merged
merged 2 commits into from
Sep 12, 2024
Merged

fix(supervisor): failing tests, chores #5070

merged 2 commits into from
Sep 12, 2024

Conversation

0x009922
Copy link
Contributor

Context

#4716 broke some tests.

Solution

This PR fixes kura_not_miss_replace_block, increases timeout for can_monitor_os_thread_spawn (broken in #4996), and does some other chores.

It doesn't fix restarted_peer_should_have_the_same_asset_amount as it requires deeper refactoring (WiP).

Checklist

  • I've read CONTRIBUTING.md.
  • (optional) I've written unit tests for the code changes.
  • All review comments have been resolved.
  • All CI checks pass.

@0x009922 0x009922 added Bug Something isn't working Tests labels Sep 11, 2024
@0x009922 0x009922 self-assigned this Sep 11, 2024
nxsaken
nxsaken previously approved these changes Sep 12, 2024
View reviewed changes
DCNick3
DCNick3 previously approved these changes Sep 12, 2024
View reviewed changes
@0x009922 0x009922 changed the title fix(supervisor): failing tests, chores fix: chores, supervisor-related test failures Sep 12, 2024
@0x009922 0x009922 changed the title fix: chores, supervisor-related test failures fix(supervisor): failing tests, chores Sep 12, 2024
@nxsaken
Copy link
Contributor

nxsaken commented Sep 12, 2024

kura_not_miss_replace_block still fails

@0x009922 0x009922 dismissed stale reviews from DCNick3 and nxsaken via 091f73d September 12, 2024 07:12
@mversic mversic force-pushed the fix/supervisor-chores branch 2 times, most recently from dc374fd to 548f810 Compare September 12, 2024 07:54
@nxsaken nxsaken merged commit bc2f46b into main Sep 12, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mversic mversic mversic approved these changes

@nxsaken nxsaken nxsaken approved these changes

@DCNick3 DCNick3 DCNick3 left review comments

@s8sato s8sato Awaiting requested review from s8sato s8sato is a code owner

@SamHSmith SamHSmith Awaiting requested review from SamHSmith SamHSmith is a code owner

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@Erigara Erigara Awaiting requested review from Erigara

@dima74 dima74 Awaiting requested review from dima74 dima74 is a code owner

Assignees

@DCNick3 DCNick3

@nxsaken nxsaken

@0x009922 0x009922

Labels
Bug Something isn't working Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0x009922 @nxsaken @DCNick3 @mversic