-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update substrate integration test environment #931
Update substrate integration test environment #931
Conversation
If this is still a work in progress, you should mark your PR as a draft and not request a review. |
@athei maybe you want to have a quick look as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, this is already a big improvement (note the typo)
There is a Substrate documentation section in docs/targets/substrate.rst
which is also out of date.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3486010
to
29b0654
Compare
@xermicus please squash merge or squash your commits into a single commit before merging |
Signed-off-by: Cyrill Leutwiler <[email protected]>
Signed-off-by: Cyrill Leutwiler <[email protected]>
Signed-off-by: Cyrill Leutwiler <[email protected]>
Signed-off-by: Cyrill Leutwiler <[email protected]>
Signed-off-by: Cyrill Leutwiler <[email protected]>
…or a single contract deploy Signed-off-by: Cyrill Leutwiler <[email protected]>
Signed-off-by: Cyrill Leutwiler <[email protected]>
Signed-off-by: Cyrill Leutwiler <[email protected]>
Signed-off-by: Cyrill Leutwiler <[email protected]>
…lang#666 so we can enable them again afterwards Signed-off-by: Cyrill Leutwiler <[email protected]>
Signed-off-by: Cyrill Leutwiler <[email protected]>
Signed-off-by: Cyrill Leutwiler <[email protected]>
Signed-off-by: Cyrill Leutwiler <[email protected]>
Signed-off-by: Cyrill Leutwiler <[email protected]>
Signed-off-by: Cyrill Leutwiler <[email protected]>
421c0c4
to
f5c4dd3
Compare
@athei FYI I updated the issue666 test spec to reproduce the exact same issue that is described there (expecting it to fail so CI is green). |
Nice. Thanks :) |
This PR upgrades the Substrate integration tests to work with an up-to-date Substrate runtime. The individual commits resemble more or less the steps needed to make this work. In summary:
pullparitytech/contracts-ci-linux:production
image for having a node that will always be up-to-dateThe regressions are most likely all related to issue #666. As discussed in today's stand up call, the plan is the following:
README.md
transparently informs what is not working and that we are aware.AccountId
toseal_call
on substrate #666 (and other potential metadata issues that may be discovered). Ideally this fixes all regressions.