Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whisper frame is not adjusted on orientation change #19

Closed
andriichernenko opened this issue Dec 21, 2015 · 2 comments · Fixed by #20
Closed

Whisper frame is not adjusted on orientation change #19

andriichernenko opened this issue Dec 21, 2015 · 2 comments · Fixed by #20

Comments

@andriichernenko
Copy link

Steps to reproduce:

  1. Show whisper
  2. Change device orientation while it is still visible

Result:
Device width changes, but whisper width remains the same.
@zenangst
Copy link
Contributor

Hey @deville, thanks for reporting this issue. Right of the bat, I think this could be fixed by adding an observer on the WhisperView. Namely UIDeviceOrientationDidChangeNotification, so if the orientation were to change while it is being displayed, it would re-render itself in the right position. We will look into this issue and keep you posted. Thanks for using and supporting Whisper ❤️

@haithngnbak
Copy link

I have tried show Whisper in navigationcontroller that has a UITableView and it make the tableview wrong top margin.

@arthur-here arthur-here mentioned this issue Dec 23, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed Shout and Whisper frame on screen rotation.
3 participants
@zenangst @haithngnbak @andriichernenko