Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whisper effect it's superview when it's called to show in viewDidLoad or viewDidAppear #22

Closed
haithngnbak opened this issue Dec 24, 2015 · 11 comments

Comments

@haithngnbak
Copy link

Hello,
Merry X-Mas !

I have a problem when I try to show Whisper at the functions viewDidLoad or viewDidAppear the tableview add strange space at it's top, please take a look in to the attached photo
screen shot 2015-12-25 at 12 42 48 am

if I show Whisper by using the button it work perfect.

You could found this bug in my demo project : https://github.com/0x686169/NiceWhisper

Hope you fix this soon as soon.

Thank you very much,

@arthur-here
Copy link
Contributor

This problem is that moveControllerViews(down:) is called twice:

  1. Firstly from viewDidAppear/viewDidLoad stack when Whisper is shown
  2. And second time in UINavigationControllerDelegate's method - navigationController(navigationController: UINavigationController, willShowViewController viewController: UIViewController, animated: Bool)

@haithngnbak
Copy link
Author

@burntheroad,
Sorry where is moveControllerViews ? I'm still not get your idea :D
the function self.show() is just called one time at viewDidAppear, Can you set debug break point at that line.
And can you fix this issue in my demo preject ?

Thanks,

@arthur-here
Copy link
Contributor

@0x686169,
Sorry for unclear comment. I talk about issue in Whisper's source, which I don't know how to fix yet. 😔

@RamonGilabert
Copy link
Contributor

Looking at it now! Thank you for reporting @0x686169 and thank you @burntheroad :)

@RamonGilabert
Copy link
Contributor

Fixed in #33, it's like a small patch, but it's basically an if that tells if the view is down already and the whisper is being shown. If that's the case, it won't do anything.

Try after it's merged and keep us posted! :)

@haithngnbak
Copy link
Author

Are you still working on this ?

@haithngnbak
Copy link
Author

still doesn't work

@zenangst zenangst reopened this Jan 5, 2016
@zenangst
Copy link
Contributor

zenangst commented Jan 5, 2016

@0x686169 we will have another look 😎

@RamonGilabert
Copy link
Contributor

We didn't update CocoaPods yet though @0x686169, that means that to try it out you need to point to master in your podfile.

@haithngnbak
Copy link
Author

hi @RamonGilabert ,
I'm using Carthage :)

@haithngnbak
Copy link
Author

Wow,
Today I checkout the latest code and I don't see this bug :(.

Thanks agains,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants