Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numpy20 fixes #29

Merged
merged 3 commits into from
Mar 31, 2024
Merged

Numpy20 fixes #29

merged 3 commits into from
Mar 31, 2024

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Mar 31, 2024

Progress of the PR

  • Fix numpy 1.25 deprecation - pytest -Werror pass,
  • [n/a] docstring updated (if appropriate),
  • [n/a] update user guide (if appropriate),
  • update tests,
  • add a changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • Check formatting of the changelog entry (and eventual user guide changes) in the docs/readthedocs.org:holospy build of this PR (link in github checks)
  • ready for review.

…backend is used the figure will be shown when calling `plt.subplots`
@ericpre ericpre added this to the v0.2 milestone Mar 31, 2024
Copy link

codecov bot commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.23%. Comparing base (18c289b) to head (298a5b2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   87.27%   87.23%   -0.04%     
==========================================
  Files           7        7              
  Lines         330      329       -1     
  Branches       73       73              
==========================================
- Hits          288      287       -1     
  Misses         25       25              
  Partials       17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlaehne jlaehne merged commit 8541538 into hyperspy:main Mar 31, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants