Fix docstring #30
Merged
Fix docstring #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
=======================================
Coverage 87.23% 87.23%
=======================================
Files 7 7
Lines 329 329
Branches 73 73
=======================================
Hits 287 287
Misses 25 25
Partials 17 17 ☔ View full report in Codecov by Sentry. |
ericpre
added
documentation
jlaehne
reviewed
Mar 31, 2024
| @@ -25,18 +25,18 @@ | |||
|
|
|||
|
|
|||
| def estimate_sideband_position( | |||
| holo_data, holo_sampling, central_band_mask_radius=None, sb="lower", high_cf=True | |||
| data, sampling, central_band_mask_radius=None, sb="lower", high_cf=True | |||
There was a problem hiding this comment.
The proposed renaming of parameters does make sense after the split, but shouldn't it be mentioned explicitly in the changelog?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress of the PR
upcoming_changesfolder (seeupcoming_changes/README.rst),docs/readthedocs.org:holospybuild of this PR (link in github checks)