Discussion: future development

[mojoaxel]

🎉 I'm happy that ngx-vis is now part of the visjs family!

We should discuss the future of this repository and how we could integrate it more.

Here are my first thoughts as a basis for a discussion:

1. I would say one of the first steps should be to move the dependency from vis to vis-timeline and vis-network. see switch to the new visjs libraries #314
2. The typescript types from vis-timeline and vis-network should be used in the future. @types/vis is also deprecated.
3. I think the next step should be to seperate ngx-vis into it's modules e.g. @visjs/ngx-vis-timeline and @visjs/ngx-network. This could e.g. be done with a monorepo approach!?
4. The "donate" section of the README should be removed in favor of a opencollective badge.
5. cicle-ci? auto-release? code-formating?

[Thomaash]

Reexported stuff from Timeline and Network will have accompanying types. I don't see any problem here. The first two bullets should be fairly simple.

[hypery2k]

I've already created a branch which can be used for 1. - 3. https://github.com/visjs/ngx-vis/tree/feature/visjs-integration

Regarding 3. Yes I would go the monorepo approach. How should the npm package be named?
@visjs/ngx or @visjs/angular ?

4. Done

5. I currently use my own Jenkins server and travis. Jenkins will produce also snapshots for npm package. If we want to switch I can live with that ;)

[mojoaxel]

Regarding 3. Yes I would go the monorepo approach. How should the npm package be named?
@visjs/ngx or @visjs/angular ?

I think the trick about the monorepo ist that the sources stay together but seperated modules can be releases out of one repository. I would recommend schema: @visjs/ngx-vis-timeline and @visjs/ngx-network ...

[hypery2k]

For the new types I've started a PR: #321

Seems to require some more changes besides simple switching imports

[hypery2k]

Just published version 3.0.0 and have also demo. Should we publish it also to the project homepage?

[mojoaxel]

Should we publish it also to the project homepage?

Because it is not an independent project but "just" another way to integrate the existing libraries I would recommend to add an "Angualar-Button" to timeline and network on visjs.org.
Also It could be useful to add a sentence about this angular component to the READMEs of those libraries.

[hypery2k]

completly overlooked your last comment (@mojoaxel): So should we add it on the README ?

[mojoaxel]

I think we should add this to https://github.com/visjs/awesome-visjs

[ericleib]

Regarding 3): How about just exporting just 2 modules instead of 1 (VisModule):

• VisNetworkModule exports VisNetworkDirective
• VisTimelineModule exports VisTimelineDirective

This simple change would allow to use the network without carrying the timeline into the bundle.

[hypery2k]

sounds great. Feel free to send a PR for that

[dsl400]

In angular 14 When importing VisTimelineDirective in a standalone component it errors out
Component imports must be standalone components, directives, pipes, or must be NgModules.

[hypery2k]

a new preview is available via npm i ngx-vis@next

For now, I will not have much time for further work on this, so closing this issue