Use DBusNamingUtil
more widely, value element added to the DeprecatedOnDBus
and MethodNoReply
annotations
#168
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR includes refactoring and fix in two annotations.
The
DBusNamingUtil
helper methods give us a simpler and safer way to retrieve DBus names.In this PR, I replaced the code fragments with methods from
DBusNamingUtil
, which reduced the boilerplate code.The next change affects the two annotations
@DeprecatedOnDBus
and@MethodNoReply
.So far when we used first of these annotations on an interface, it produced the following introspection data:
Referring to the https://dbus.freedesktop.org/doc/dbus-specification.html#introspection-format specification, the value should be true or false.
So I added the appropriate value element with default value true to the annotation, now the introspection data looks like this:
Best regards,
MK