Semver validation error thrown when indexation needed

[asayah]

S3 plugin was throwing semver validation error even if my version was valid, got fixed by re-indexing, error handling should be improved.

[fradeve]

We noticed the same error when uploading a chart to the S3 bucket, after upgrading from 1.59.6 to 1.59.7:

$ helm s3 push --force /builds/ubiquitypress/$IMAGE_NAME/$IMAGE_NAME-$VERSION.tgz ubiquity
add/replace chart in the index: Invalid Semantic Version
Error: plugin "s3" exited with error
ERROR: Job failed: command terminated with exit code 1

we run version 0.8

[tkoeppen]

We got the same error with "helm s3 push" after we added helm charts to our helm repo with versions which seem not follow https://semver.org/

e.g
version: 1.2.3-name1-name2 (version names with 2 "-")

instead of 1.2.3-name1 or 1.2.3-name.1

My workaround:

1. copy charts to local dir
   aws s3 sync s3://$bucketname $localdir

2. delete affected charts from $localdir

3. copy charts back to s3
   aws s3 sync $localdir s3://$bucketname

We run
$ helm s3 version
0.9.2
$ helm version
version.BuildInfo{Version:"v3.4.2", GitCommit:"23dd3af5e19a02d4f4baa5b2f242645a1a3af629", GitTreeState:"dirty", GoVersion:"go1.15.5"}