Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bedtools merge fails #12

Closed
edmundmiller opened this issue Sep 7, 2022 · 2 comments
Closed

Bedtools merge fails #12

edmundmiller opened this issue Sep 7, 2022 · 2 comments

Comments

@edmundmiller
Copy link

edmundmiller commented Sep 7, 2022

With a small test dataset, but it doesn't fail for homer/grohmm

Steps to reproduce

  1. Install nextflow curl -s https://get.nextflow.io | bash
  2. NXF_VER=21.10.3 ./nextflow run nf-core/nascent -r pints -profile test,docker --outdir results
@liyao001
Copy link
Collaborator

liyao001 commented Sep 8, 2022

Thanks a lot for incorporating PINTS to the nascent transcription processing pipeline! I'll try to reproduce this issue, and report back.

@liyao001 liyao001 mentioned this issue Sep 22, 2022
liyao001 added a commit to liyao001/PINTS that referenced this issue Oct 8, 2022
[Changed]: Prints info instead of a warning message when `--min-mu-percent` related issues are detected.
[Changed]: Reduce redundancy in the function `peak_calling` by abstracting statements about parsing input files.
[Added]: Added a new QC metric on the number of significant calls. If the number of significant calls is too large, PINTS will throw a warning message and suggest users switch to a more strict FDR cutoff.
liyao001 added a commit that referenced this issue Oct 8, 2022
@liyao001
Copy link
Collaborator

liyao001 commented Oct 8, 2022

Sorry for the delay! I reproduced the error with the inputs you provided. This error happened when PINTS tried to merge all predictions while specific type(s) of predictions (bidirectional/divergent/unidirectional peaks) were empty. I fixed this problem in the recent commit, and I'll post updates to nf-core/nascent#39 when the new release is reflected on the bioconda channel. Again, thanks a lot for helping us spot this bug!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants