Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run_sgrna_quant report the wrong sequences associated to sgRNA names #14

Closed
DaneseAnna opened this issue Jun 7, 2022 · 2 comments
Closed

Comments

@DaneseAnna
Copy link

Thank you very much for the CB2 package, it is great and provides us with the quantification of the sgRNA in a very quick and easy way.

When running run_sgrna_quant it output the correct count matrix in regards to the ref. sgRNA names. But the sequences associated with the ref. sgRNA are incorrect. It seems to arise from the C++ fucntion quant. It returns Rcpp::_["sequence"] = ref.seq , which somehow is not working. Replacing ref.seq with sgRNA_hash hopefully fixes the problem.

I am unsure about the fix but hopefully, you can find an easy solution to return the correct sequences associated with the ref. sgRNA names.

@hyunhwan-jeong
Copy link
Owner

Hi @DaneseAnna, thanks for reporting this. Yes, you are correct, and I made a quick fix. You are able to install CB2 using devtools, and I will submit the new version to CRAN, but it will take time. Let me know if you have any issue. I will close the issue once you confirm that it gets fixed.

Kind regards,

Hyun-Hwan Jeong

@DaneseAnna
Copy link
Author

Hi @hyunhwan-jeong, my colleague tested the fix and it works. Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants