Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change typing of Corpus.slice args #79

Open
jumelet opened this issue Mar 26, 2021 · 0 comments
Open

Change typing of Corpus.slice args #79

jumelet opened this issue Mar 26, 2021 · 0 comments
Labels
refactor

Comments

@jumelet
Copy link
Collaborator

jumelet commented Mar 26, 2021

diagNNose/diagnnose/corpus/corpus.py

Line 149 in 76d9fe1

def slice(self, sen_ids: List[int]) -> "Corpus":

Not restricted to List[int], can be any type of iterator.
@jumelet jumelet changed the title Change typing of slice args Change typing of Corpus.slice args Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jumelet