Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify data/datasets folders into single folder / interface #8

Open
gautierdag opened this issue Jul 29, 2019 · 2 comments
Open

Unify data/datasets folders into single folder / interface #8

gautierdag opened this issue Jul 29, 2019 · 2 comments

Comments

@gautierdag
Copy link
Member

gautierdag commented Jul 29, 2019

I suggest unifying the data/datasets tasks into a single folder, along with some of the helper files (the relevant dataset/data ones) and the enums and samplers folder.

@Saduras
Copy link
Collaborator

Saduras commented Aug 4, 2019

Does any other project share the same/similar datasets? Are they any plans to use it for other projects?
Without a use-case in the near future, I would question the value that this refactoring brings for now. We can still attempt it when a use-case comes up.

@gautierdag
Copy link
Member Author

Sorry, I meant folder, not repo. Essentially bringing all data/dataset functions under one folder, then subdivided by actual dataset such as data/shapes .. etc . The idea is that we can then extend to a new dataset/task without much refactoring. And provide a single interface to import a specific dataset/task. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants