Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat users who dev_block a pull as being subscribed to that pull (as if they'd CRed it) #193

Open
andyg0808 opened this issue Nov 24, 2020 · 0 comments · May be fixed by #381
Open

Treat users who dev_block a pull as being subscribed to that pull (as if they'd CRed it) #193

andyg0808 opened this issue Nov 24, 2020 · 0 comments · May be fixed by #381
Assignees
@danielbeardsley

Comments

@andyg0808
Copy link
Contributor

andyg0808 commented Nov 24, 2020 •
edited
Loading

As a developer
I want to have dev_block treated as a review
So that I notice when it gets un_dev_blocked.

Sometimes when we review a pull, it's not ready to ship. Rather than marking it as approved (with CR), we need to dev_block it for further work. When we do that, we want that pull to show up as having an out-of-date CR when it gets un_deploy_blocked, so that we can re-CR (and hopefully approve it). This also avoids looking at pulls which have another dev already involved in CRing if we don't want to.
@danielbeardsley danielbeardsley self-assigned this May 19, 2023
danielbeardsley added a commit that referenced this issue May 19, 2023
@danielbeardsley
Signatures: treat dev_block as out-of-date CR
35c9ea7 
When you "dev_block" something, have that inject a "synthetic" but
out-of-date CR signature in the UI. This means that a dev_block somewhat
reserves a place for you to CR it in the future.

Most dev_blocks come after a review and we generally presume that the
dev blocker will come back and CR it after the requested changes have
been made. Therefore, we now show a dev_block as an "inactive" CR.

Also, move the typescript comment to the line it's referring to.

Closes #193
@danielbeardsley danielbeardsley linked a pull request May 19, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielbeardsley danielbeardsley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Signatures: treat dev_block as out-of-date CR 💥 iFixit/pulldasher
2 participants
@danielbeardsley @andyg0808