Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Yoke05_Barrel driver #241

Merged
merged 4 commits into from
Mar 2, 2020
Merged

Fix Yoke05_Barrel driver #241

merged 4 commits into from
Mar 2, 2020

Conversation

rete
Copy link
Contributor

@rete rete commented Mar 2, 2020 •
edited
Loading

BEGINRELEASENOTES

  • Yoke05_Barrel driver:
    • Removed slices DetElement construction
    • Moved layer DetElement construction to external loop: fixes the DetElement hierarchy.
      This fixes the access to the DetElement given a CellID in our reconstruction.
      Related issue: Muon reconstruction failing iLCSoft/ILDConfig#88

ENDRELEASENOTES

@rete rete requested a review from gaede March 2, 2020 15:29
@rete rete mentioned this pull request Mar 2, 2020
Merged
gaede
gaede reviewed Mar 2, 2020
View reviewed changes
Copy link
Contributor

@gaede gaede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please remove the commented out lines - we have the diff from the PR for future reference...

detector/calorimeter/Yoke05_Barrel.cpp Outdated Show resolved Hide resolved
@rete
Copy link
Contributor Author

rete commented Mar 2, 2020

@gaede Done

@rete rete merged commit 4077621 into key4hep:master Mar 2, 2020
@rete rete deleted the fix-muon-barrel branch March 2, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaede gaede gaede approved these changes

Assignees
No one assigned
Labels
bug ILDProduction
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rete @gaede