Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues with data chunks #22

Open
frostschutz opened this issue Jul 20, 2015 · 0 comments
Open

issues with data chunks #22

frostschutz opened this issue Jul 20, 2015 · 0 comments

Comments

@frostschutz
Copy link

The readme says

  • Works with chunks of a data - no need to buffer the whole request

but it doesn't seem that simple. If a header happens to be in a chunk boundary, you get double callback calls with half a header field name in each. So instead of blindly passing whatever data was available I have to do my own buffering, or track state and buffer whatever I get in the callbacks.

The part_data callback also is very noisy, it gets tons of calls for 1 byte or even 0 byte even if the data chunk the parser currently works on is considerably larger and a larger data block could be passed along consecutively w/o additional buffering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant