Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema.org tests should only apply to Schema.org schemas #17

Open
iaincollins opened this issue Mar 12, 2020 · 1 comment
Open

Schema.org tests should only apply to Schema.org schemas #17

iaincollins opened this issue Mar 12, 2020 · 1 comment
Labels
bug Something isn't working pre-release Issues that do not impact the live version, only the pre-release version
Milestone
Version 5.0

Comments

@iaincollins
Copy link
Owner

iaincollins commented Mar 12, 2020 •
edited
Loading

Describe the bug
The new Schema.org property tests (which are in master but not in the release version) should only apply to Schema.org schemas.

Currently the tool assumes schemas are Schema.org schemas, which is what is most common, but to be technically correct the tool should check the schema type.
@iaincollins iaincollins added the bug Something isn't working label Mar 12, 2020
@iaincollins iaincollins added this to the Version 5.0 milestone Mar 12, 2020
@iaincollins iaincollins added the pre-release Issues that do not impact the live version, only the pre-release version label Mar 14, 2020
@iaincollins
Copy link
Owner Author

To confirm, this bug does not apply to the current release (4.x) and only to the version in development that is not released yet (5.x).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working pre-release Issues that do not impact the live version, only the pre-release version
Projects
None yet
Milestone
Version 5.0
Development

No branches or pull requests
1 participant
@iaincollins