Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing tool skips invalid JSON should report as a failure #24

Open
dougnukem opened this issue Jun 11, 2020 · 1 comment
Open

Testing tool skips invalid JSON should report as a failure #24

dougnukem opened this issue Jun 11, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@dougnukem
Copy link

dougnukem commented Jun 11, 2020

Describe the bug
sdtt does not report invalid JSON syntax errors as a failure and skips those JSON-LD blocks.

$ sdtt --url https://supplydrop.com
Error in jsonld parse - SyntaxError: Unexpected end of JSON input
Tests

  Schema.org > FAQPage - 100% (1 passed, 0 failed)
    ✓  schema in jsonld

Statistics

  Number of Metatags: 19
  Schemas in JSON-LD: 1
     Schemas in HTML: 0
      Schema in RDFa: 0
  Schema.org schemas: FAQPage
       Other schemas: 0
     Test groups run: 2
  Optional tests run: 44
 Pass/Fail tests run: 1

Results

    Passed: 1 	(100%)
  Warnings: 0 	(0%)
    Failed: 0 	(0%)

  ✓ 1 tests passed with 0 warnings.

The google validator reports that as an error:
https://search.google.com/structured-data/testing-tool/u/0/#url=https%3A%2F%2Fsupplydrop.com

Missing ',' or '}' in object declaration.

@dougnukem dougnukem added the bug Something isn't working label Jun 11, 2020
@iaincollins
Copy link
Owner

Thanks! I agree, that is something that should improved by communicating more clearly.

I'm going to re-classify as an enhancement in this case, so that other things that are more obviously defects (rather than sins of omission) can be prioritised.

@iaincollins iaincollins added enhancement New feature or request and removed bug Something isn't working labels Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants