fixes #111

[Macarse]

What I did

Found the source of the issue:
https://github.com/ethereum/solc-bin/tree/gh-pages/windows-amd64

Starting 0.7.2 they are exes

Related issue: #111

How I did it

mmmm I don't know what you expect me to write here

How to verify it

I am not running windows

Checklist

• I have confirmed that my PR passes all linting checks
• I have included test cases
• I have updated the documentation (README.md)
• I have added an entry to the changelog

ok, I didn't do any of those. pytest failed

$ pytest tests
ERROR: usage: pytest [options] [file_or_dir] [file_or_dir] [...]
pytest: error: unrecognized arguments: --cov=solcx --cov-branch --cov-report
  inifile: /Users/x/dev/py-solc-x/setup.cfg
  rootdir: /Users/x/dev/py-solc-x

and I am not sure if I will be able to test windows behavior outside of windows.

[iamdefinitelyahuman]

Looks like this is failing at least in part due to an unrelated issue. I should be able to look at it soon. Thanks for your help with this!

[iamdefinitelyahuman]

I think the issue here is that on windows systems, solc is placed in a unique folder for each installation. This is required because zipped versions include a separate DLL file.

The simplest approach would then be to use the same file structure for these new non-zipped executables:

Suggested change

	if filename.endswith("exe"):
	with open(install_path, "wb") as fp:
	fp.write(content)
	if filename.suffix == ".exe":
	install_path.mkdir()
	with open(install_path.joinpath("solc.exe"), "wb") as fp:
	fp.write(content)

[Macarse]

sure, do you have a way to test it? I don't have a windows box :(

[Macarse]

AttributeError: 'str' object has no attribute 'suffix'

[iamdefinitelyahuman]

ooooh... my bad! Path(filename).suffix