Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update solc_wrapper to expect return value of 0 from 'help' if solc >= v0.8.10 #140

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

pacrob
Copy link

@pacrob pacrob commented Jan 7, 2022

What I did

Starting with solc v0.8.10, running solc --help gives a return value of 0. It was previously 1. I added version checking to expect the correct value.

How I did it

I checked if the solc version being used was < v0.8.10 and set the expected return value accordingly.

How to verify it

Run the tests

Checklist

  • I have confirmed that my PR passes all linting checks
  • I have included test cases
  • I have updated the documentation (README.md)
  • I have added an entry to the changelog

@pacrob
Copy link
Author

pacrob commented Jan 7, 2022

Lint wouldn't work even on master, but I matched the surrounding code style.
pre-commit threw mypy errors on code I didn't touch - I'd fix it if I knew how, but it's out of scope for this fix.

It doesn't seem appropriate for docs or changelog, but I'm happy to do so if you'd like.

@philogicae
Copy link

Great job. Why is this pull request still in pending since 6 months ?

@antazoey
Copy link
Member

antazoey commented Nov 9, 2023

thank you, this was also causing problems for me

@antazoey
Copy link
Member

antazoey commented Nov 9, 2023

btw im fixing all lint, tests, and type stuff on another branch.
we are cleaning this package up and getting it updated because it has been causing lots of issues, such as this one.

@antazoey antazoey merged commit b6c2ef9 into ApeWorX:main Nov 9, 2023
@pacrob pacrob deleted the new_help_return_code_in_v0.8.10 branch November 11, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants