Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module): transpile everything except ES6 modules in the 'module' entrypoint (#477) (#480) #482

Merged
merged 1 commit into from
Feb 7, 2019

Conversation

Tvrqvoise
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 6, 2019

Codecov Report

Merging #482 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #482   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files        56     56           
  Lines       496    496           
  Branches     80     80           
===================================
  Hits        496    496

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca49e7c...a1ad68e. Read the comment docs.

@iamkun iamkun merged commit 767017d into iamkun:dev Feb 7, 2019
iamkun pushed a commit that referenced this pull request Feb 7, 2019
## [1.8.5](v1.8.4...v1.8.5) (2019-02-07)

### Bug Fixes

* Add en-gb locale ([#478](#478)) ([508c3a7](508c3a7))
* **module:** transpile everything except ES6 modules in the 'module' entrypoint ([#477](#477)) ([#480](#480)) ([#482](#482)) ([767017d](767017d))
* update customParseFormat plugin support hh:mm ([54947cc](54947cc)), closes [#484](#484)
* Update module in package.json ([5c5a7a0](5c5a7a0))
@iamkun
Copy link
Owner

iamkun commented Feb 7, 2019

🎉 This PR is included in version 1.8.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@iamkun iamkun added the released label Feb 7, 2019
@malixsys
Copy link

This broke my imports in Typescript... :(

@Tvrqvoise
Copy link
Contributor Author

@malixsys did they work in 1.8.4?

@malixsys
Copy link

malixsys commented Feb 12, 2019

@Tvrqvoise I just saw that I updated from 1.7.8 (had latest in package.json)

ModuleDependencyWarning: "export 'extend' (imported as 'dayjs') was not found in 'dayjs'

@malixsys
Copy link

malixsys commented Feb 12, 2019

Versions > 1.7.8 cannot be universally imported in my next.js app...

import dayjs from 'dayjs' gives undefined
import * from dayjs from 'dayjs' does not export extend properly

@iamkun
Copy link
Owner

iamkun commented Feb 13, 2019

@malixsys any reproduction repo please?

andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.5](iamkun/dayjs@v1.8.4...v1.8.5) (2019-02-07)

### Bug Fixes

* Add en-gb locale ([#478](iamkun/dayjs#478)) ([508c3a7](iamkun/dayjs@508c3a7))
* **module:** transpile everything except ES6 modules in the 'module' entrypoint ([#477](iamkun/dayjs#477)) ([#480](iamkun/dayjs#480)) ([#482](iamkun/dayjs#482)) ([767017d](iamkun/dayjs@767017d))
* update customParseFormat plugin support hh:mm ([54947cc](iamkun/dayjs@54947cc)), closes [#484](iamkun/dayjs#484)
* Update module in package.json ([5c5a7a0](iamkun/dayjs@5c5a7a0))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.5](iamkun/dayjs@v1.8.4...v1.8.5) (2019-02-07)

### Bug Fixes

* Add en-gb locale ([#478](iamkun/dayjs#478)) ([508c3a7](iamkun/dayjs@508c3a7))
* **module:** transpile everything except ES6 modules in the 'module' entrypoint ([#477](iamkun/dayjs#477)) ([#480](iamkun/dayjs#480)) ([#482](iamkun/dayjs#482)) ([767017d](iamkun/dayjs@767017d))
* update customParseFormat plugin support hh:mm ([54947cc](iamkun/dayjs@54947cc)), closes [#484](iamkun/dayjs#484)
* Update module in package.json ([5c5a7a0](iamkun/dayjs@5c5a7a0))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants