Fix double meaning for nb locale #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #679 +/- ##
===================================
Coverage 100% 100%
===================================
Files 154 154
Lines 1015 1015
Branches 156 156
===================================
Hits 1015 1015
Continue to review full report at Codecov.
|
|
Thanks |
iamkun
pushed a commit
that referenced
this pull request
Nov 6, 2019
## [1.8.17](v1.8.16...v1.8.17) (2019-11-06) ### Bug Fixes * Fix set utcOffset in utc mode ([d148115](d148115)) * Update advancedFormat plugin to support w ww wo week tokens … ([#678](#678)) ([26cfa63](26cfa63)), closes [#676](#676) * Update ka locale weekdays ([f8ca3d4](f8ca3d4)) * Update nb locale ([#679](#679)) ([1063b0e](1063b0e)) * Update Polish locale (pl)([#713](#713)) ([30d2f02](30d2f02)) * Update Ukrainian locale (uk) ([#710](#710)) ([360161c](360161c)) * UTC plugin set utcOffset value ([#668](#668)) ([8877883](8877883))
|
🎉 This PR is included in version 1.8.17 🎉 The release is available on: Your semantic-release bot 📦🚀 |
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
## [1.8.17](iamkun/dayjs@v1.8.16...v1.8.17) (2019-11-06) ### Bug Fixes * Fix set utcOffset in utc mode ([d148115](iamkun/dayjs@d148115)) * Update advancedFormat plugin to support w ww wo week tokens … ([#678](iamkun/dayjs#678)) ([26cfa63](iamkun/dayjs@26cfa63)), closes [#676](iamkun/dayjs#676) * Update ka locale weekdays ([f8ca3d4](iamkun/dayjs@f8ca3d4)) * Update nb locale ([#679](iamkun/dayjs#679)) ([1063b0e](iamkun/dayjs@1063b0e)) * Update Polish locale (pl)([#713](iamkun/dayjs#713)) ([30d2f02](iamkun/dayjs@30d2f02)) * Update Ukrainian locale (uk) ([#710](iamkun/dayjs#710)) ([360161c](iamkun/dayjs@360161c)) * UTC plugin set utcOffset value ([#668](iamkun/dayjs#668)) ([8877883](iamkun/dayjs@8877883))
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
## [1.8.17](iamkun/dayjs@v1.8.16...v1.8.17) (2019-11-06) ### Bug Fixes * Fix set utcOffset in utc mode ([d148115](iamkun/dayjs@d148115)) * Update advancedFormat plugin to support w ww wo week tokens … ([#678](iamkun/dayjs#678)) ([26cfa63](iamkun/dayjs@26cfa63)), closes [#676](iamkun/dayjs#676) * Update ka locale weekdays ([f8ca3d4](iamkun/dayjs@f8ca3d4)) * Update nb locale ([#679](iamkun/dayjs#679)) ([1063b0e](iamkun/dayjs@1063b0e)) * Update Polish locale (pl)([#713](iamkun/dayjs#713)) ([30d2f02](iamkun/dayjs@30d2f02)) * Update Ukrainian locale (uk) ([#710](iamkun/dayjs#710)) ([360161c](iamkun/dayjs@360161c)) * UTC plugin set utcOffset value ([#668](iamkun/dayjs#668)) ([8877883](iamkun/dayjs@8877883))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"for %s siden" is a double meaning, "for" means "for" and "siden" means since. The translation here is basically
for %s since.In Norwegian it works, and it's a common way to communicate verbally, but in writing it becomes redundant. I've also read that you like to keep these things similar to Moment, which is what I'm switching from, and I reacted on this immediately :/
As a side note, the language name here should be
nb_NOor from what I can gather from your structureno-nb. Norway has two official languages, that beingnb_NOandnn_NO