feat(ts): add missing locale type definitions #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #716 +/- ##
===================================
Coverage 100% 100%
===================================
Files 154 154
Lines 1017 1017
Branches 157 157
===================================
Hits 1017 1017Continue to review full report at Codecov.
|
|
@iamkun Any time to review this? |
iamkun
reviewed
Nov 6, 2019
iamkun
reviewed
Nov 6, 2019
|
？？？@iamkun What's going on? Can you please take care of this? |
|
We will merge all the incoming features before the next release, thanks for your concern. |
|
@iamkun I saw you're merging other PRs during these days, so I was thinking is there anything wrong with this PR. |
|
Oh, I see, the PRs get merged quickly are all chore fix. |
|
Well, follow your own schedule then. Cheers. 🍺 |
|
@iamkun Sorry I have to asking for releasing it again here, it is really needed... |
|
@JounQin let's make it merged today! |
|
@iamkun Thx! |
iamkun
pushed a commit
that referenced
this pull request
Dec 18, 2019
## [1.8.18](v1.8.17...v1.8.18) (2019-12-18) ### Bug Fixes * Add missing locale type definition ([#716](#716)) ([cde5d0b](cde5d0b)) * Fix .locale() handel unsupported locale ([78ec173](78ec173)) * Update Italian locale (it) ([#727](#727)) ([5b53e98](5b53e98)) * Update locale (fa) ([#733](#733)) ([9ad2e47](9ad2e47)) * Update locale (zh-cn) ([#706](#706)) ([e31e544](e31e544)) * Update locale (zh-cn) meridiem ([#735](#735)) ([15d1b81](15d1b81)) * Update LocaleData plugin to support dayjs().longDateFormat() ([#734](#734)) ([aa0f210](aa0f210)), closes [#680](#680) * Update Mongolian (mn) locale relativeTime ([#753](#753)) ([6d51435](6d51435)) * Update Swedish locale (sv) fix ordinal error ([#745](#745)) ([49670d5](49670d5)), closes [#743](#743)
|
🎉 This PR is included in version 1.8.18 🎉 The release is available on: Your semantic-release bot 📦🚀 |
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
## [1.8.18](iamkun/dayjs@v1.8.17...v1.8.18) (2019-12-18) ### Bug Fixes * Add missing locale type definition ([#716](iamkun/dayjs#716)) ([cde5d0b](iamkun/dayjs@cde5d0b)) * Fix .locale() handel unsupported locale ([78ec173](iamkun/dayjs@78ec173)) * Update Italian locale (it) ([#727](iamkun/dayjs#727)) ([5b53e98](iamkun/dayjs@5b53e98)) * Update locale (fa) ([#733](iamkun/dayjs#733)) ([9ad2e47](iamkun/dayjs@9ad2e47)) * Update locale (zh-cn) ([#706](iamkun/dayjs#706)) ([e31e544](iamkun/dayjs@e31e544)) * Update locale (zh-cn) meridiem ([#735](iamkun/dayjs#735)) ([15d1b81](iamkun/dayjs@15d1b81)) * Update LocaleData plugin to support dayjs().longDateFormat() ([#734](iamkun/dayjs#734)) ([aa0f210](iamkun/dayjs@aa0f210)), closes [#680](iamkun/dayjs#680) * Update Mongolian (mn) locale relativeTime ([#753](iamkun/dayjs#753)) ([6d51435](iamkun/dayjs@6d51435)) * Update Swedish locale (sv) fix ordinal error ([#745](iamkun/dayjs#745)) ([49670d5](iamkun/dayjs@49670d5)), closes [#743](iamkun/dayjs#743)
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
## [1.8.18](iamkun/dayjs@v1.8.17...v1.8.18) (2019-12-18) ### Bug Fixes * Add missing locale type definition ([#716](iamkun/dayjs#716)) ([cde5d0b](iamkun/dayjs@cde5d0b)) * Fix .locale() handel unsupported locale ([78ec173](iamkun/dayjs@78ec173)) * Update Italian locale (it) ([#727](iamkun/dayjs#727)) ([5b53e98](iamkun/dayjs@5b53e98)) * Update locale (fa) ([#733](iamkun/dayjs#733)) ([9ad2e47](iamkun/dayjs@9ad2e47)) * Update locale (zh-cn) ([#706](iamkun/dayjs#706)) ([e31e544](iamkun/dayjs@e31e544)) * Update locale (zh-cn) meridiem ([#735](iamkun/dayjs#735)) ([15d1b81](iamkun/dayjs@15d1b81)) * Update LocaleData plugin to support dayjs().longDateFormat() ([#734](iamkun/dayjs#734)) ([aa0f210](iamkun/dayjs@aa0f210)), closes [#680](iamkun/dayjs#680) * Update Mongolian (mn) locale relativeTime ([#753](iamkun/dayjs#753)) ([6d51435](iamkun/dayjs@6d51435)) * Update Swedish locale (sv) fix ordinal error ([#745](iamkun/dayjs#745)) ([49670d5](iamkun/dayjs@49670d5)), closes [#743](iamkun/dayjs#743)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@iamkun This PR improves locale user experience for TypeScript users, please help to review.