Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difference between locale fr monthsShort abbreviation and moment.js abbreviation #861

Closed
PierrickGT opened this issue Apr 8, 2020 · 3 comments

Comments

@PierrickGT
Copy link
Contributor

Describe the bug
Fr locale abbreviations for monthsShort differ from Moment.js ones since a dot is missing at the end of months with more than 4 letters.

Here is the code line concerned:
https://github.com/moment/moment/blob/13a61b285c095bda7ea8e33156090ea5ccfeaef1/locale/fr.js#L13

monthsShort: 'janv_févr_mars_avril_mai_juin_juil_août_sept_oct_nov_déc'.split('_'),

Expected behavior
I expect to have the same abbreviations than Moment.js

Information

  • Day.js Version: 1.8.23
  • OS: Mac OS 10.15.4
  • Browser: Chrome 80.0.3987.163
  • Time zone: GMT+01:00
@iamkun
Copy link
Owner

iamkun commented Apr 8, 2020

Can you send us a PR with the correct one, please?

@PierrickGT
Copy link
Contributor Author

Can you send us a PR with the correct one, please?

Here you go: #862

@iamkun
Copy link
Owner

iamkun commented Apr 8, 2020

Cool thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants