Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with dplyr 0.6.0 release candidate #5

Closed
ianmcook opened this issue Apr 14, 2017 · 5 comments
Closed

Test with dplyr 0.6.0 release candidate #5

ianmcook opened this issue Apr 14, 2017 · 5 comments
Assignees

Comments

@ianmcook
Copy link
Owner

Test implyr with dplyr version 0.5.0.9002.

@ianmcook ianmcook self-assigned this Apr 14, 2017
@ianmcook
Copy link
Owner Author

ianmcook commented Apr 26, 2017

df158cb builds and checks with no errors or warnings with both dplyr 0.5.0 and the current dplyr 0.6.0 release candidate. I intend to make a few more changes to this version, then release it as version 0.1.1 on CRAN ahead of Hadley's submission of dplyr 0.6.0 to CRAN on or around May 11. The goal with this release is to be compatible with both dplyr 0.5.0 and dplyr 0.6.0, so there is never a current version of implyr on CRAN that fails.

db_desc(), which replaces src_desc(), is currently just a stub. src_desc() in dplyr 0.5.0 dispatches on the src object, but db_desc() in dplyr 0.6.0 dispatches on the connection. This breaks the design I used. The next step is to fix this.

After the dplyr 0.6.0 release, I will make further changes and release a version 0.2.0 that works only with dplyr 0.6.0 and higher. This version 0.2.0 will eliminate some of the messy dplyr/dbplyr conditionals used in 0.1.1.

@ianmcook
Copy link
Owner Author

ianmcook commented May 4, 2017

aca1546 fixes the issue with db_desc() described above and builds and checks with no errors or warnings.

@ianmcook
Copy link
Owner Author

ianmcook commented May 4, 2017

Change of plans due to feedback from the CRAN team: I will create a version 0.2.0 of implyr that works only with dplyr version 0.6.0 and higher, and submit that to CRAN after dplyr 0.6.0 is on CRAN.

@ianmcook
Copy link
Owner Author

e478f88 drops compatibility with dplyr 0.5.0 and builds on the current dplyr 0.6.0 release candidate with no errors, warnings, or notes.

@ianmcook
Copy link
Owner Author

As of 3b599b6, the package is compatible with dplyr 0.7.0 (which is the new number for what was going to be 0.6.0). Closing this now, and will submit a version 0.2.0 of implyr to CRAN soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant