Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deleteLineForward borks selection range on demo #1966

Closed
mattkrick opened this issue Jul 11, 2018 · 6 comments
Closed

deleteLineForward borks selection range on demo #1966

mattkrick opened this issue Jul 11, 2018 · 6 comments

Comments

@mattkrick
Copy link

Do you want to request a feature or report a bug?

bug

What's the current behavior?

hitting delete line foward delete as expected, but the cursor ends up in the wrong spot
borkdeletelineforward

Chrome 67
Ubuntu 16.04
Slate demo website

@zhujinxuan
Copy link
Contributor

hitting delete line foward delete as expected, but the cursor ends up in the wrong spot

Can I know which key you are using? I tried ctrl-k in mac, and I cannot reproduce the result.

@mattkrick
Copy link
Author

ctrl + shift + delete on linux, on winodws that combo opens up browser options though

@zhujinxuan
Copy link
Contributor

I think the reason is ctrl + shift + delete is not captured in slate-hotkeys. I will change a PR to support it.

@zhujinxuan
Copy link
Contributor

I think it is fixed in #1888

Can you have a try of delete backward/forward in PR preview (https://deploy-preview-1888--slatejs.netlify.com/#/rich-text)

@mattkrick
Copy link
Author

confirmed working!

@ianstormtaylor
Copy link
Owner

I believe that this may be fixed by #3093, which has changed a lot of the logic in Slate and slate-react especially. I'm going to close this out, but as always, feel free to open a new issue if it persists for you. Thanks for understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants