Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createIssue conflicts with use of issue table as a cache #4

Closed
dckc opened this issue Aug 3, 2018 · 8 comments
Closed

createIssue conflicts with use of issue table as a cache #4

dckc opened this issue Aug 3, 2018 · 8 comments
Assignees

Comments

@dckc
Copy link

dckc commented Aug 3, 2018

The issue table is just a cache of data from github. Unless this createIssue mutation is going to push the change all the way to github, it makes no sense.

https://github.com/ibesoft11/graphql/blob/658a47c21bed87c7f36b7bd50c25f3e24e5745dc/schemaResolver.js#L30

@ibesoft11
Copy link
Owner

If I understand you, should I remove the createIssue mutation ?
And again, I feel not every table needs to have mutations... It'll be better if I am given a list of the tables that need mutations.

@dckc
Copy link
Author

dckc commented Aug 4, 2018

As I discussed with @jimscarver, I don't expect any mutations to come in via graphql:

  • you'd have to update the history tables to0
  • authentication would be essential
    • I'd have to review all the details of how it's done, and that doesn't get us any closer to where we want to be, which is running on RChain

@ibesoft11
Copy link
Owner

Could you please explain the kind of authentication we are talking about ?

@dckc
Copy link
Author

dckc commented Aug 4, 2018

We have to ensure that only votes by coop members are counted.

Currently we use OAuth from github and discord: rchain/bounties#413

@ibesoft11
Copy link
Owner

Ok, but I don't think the authentication would be done on this GraphQL server since we are not doing any mutations ? Only queries to existing data.

@ibesoft11 ibesoft11 self-assigned this Aug 4, 2018
@dckc
Copy link
Author

dckc commented Aug 4, 2018

It would be more clear that we're not doing any mutations if the createIssue code were gone. :)

@ibesoft11
Copy link
Owner

Yeah, I'll remove it (and every other mutation)...

@dckc
Copy link
Author

dckc commented Aug 28, 2018

fixed in d2d57b3

@dckc dckc closed this as completed Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants