Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: respect RIPGREP_CONFIG_PATH by default #1506

Closed
1 task done
looshch opened this issue Oct 30, 2024 · 3 comments
Closed
1 task done

Feature: respect RIPGREP_CONFIG_PATH by default #1506

looshch opened this issue Oct 30, 2024 · 3 comments
Labels
feature request New feature wontfix This will not be worked on

Comments

@looshch
Copy link

looshch commented Oct 30, 2024

Have you RTFM'd?

  • I have done proper research

Feature Request

i think respecting RIPGREP_CONFIG_PATH by default makes more sense since it’s a global, rc-family configuration, so naturally i imagine more people would tend to prefer it to be acknowledged as opposed to explicitly opting into it. If one doesn’t want it, setting it to false or something should do the job. What do you think? Thanks!

@looshch looshch added the feature request New feature label Oct 30, 2024
@ibhagwan
Copy link
Owner

ibhagwan commented Oct 30, 2024

We’ve been through this discussion already see #1266, the decision was against this, especially when the workaround is as easy as:

require("fzf-lua").setup({
  grep = {
    RIPGREP_CONFIG_PATH = vim.env.RIPGREP_CONFIG_PATH
  }
})

@ibhagwan ibhagwan added the wontfix This will not be worked on label Oct 30, 2024
@looshch
Copy link
Author

looshch commented Oct 30, 2024

@ibhagwan yep i know about the workaround, thanks. Sorry for the bother, when checking

  • I have done proper research

i forgot to paste the name of the option into the issues search before opening this one 🤦🏼‍♂️ Apologies!

have a good one

@ibhagwan
Copy link
Owner

No worries, Ty @looshch for your interest in the project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants