Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Issue: init paramter clientApiKey is misleading #12

Open
drcariel opened this issue Sep 30, 2016 · 0 comments
Open

Minor Issue: init paramter clientApiKey is misleading #12

drcariel opened this issue Sep 30, 2016 · 0 comments

Comments

@drcariel
Copy link

Considering that the Push service has an api key and client secret as separate values, users could get confused that you are not asking for the same in this parameter.

A change to simply apiKey would be more appropriate since there is only one api key for Analytics. Anywhere the parameter is referenced should be changed to put emphasis that this key is from your analytics service and needs to be created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant