Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build output should support Dojo loader #2

Open
cjolif opened this issue Dec 5, 2013 · 4 comments
Open

Build output should support Dojo loader #2

cjolif opened this issue Dec 5, 2013 · 4 comments
Assignees

Comments

@cjolif
Copy link
Contributor

cjolif commented Dec 5, 2013

Current build output is loadable by RequireJS but not loadable by Dojo 1.9 loader.

@ghost ghost assigned clmath Dec 5, 2013
@cjolif
Copy link
Contributor Author

cjolif commented Jan 3, 2014

And the current README should state that output is only consumable by requireJS if that is not already the case

@clmath
Copy link
Member

clmath commented Jan 6, 2014

The README now state that the plugin is currently only compatible with RequireJS AMD loader and plugins.

@jhpedemonte
Copy link

Why doesn't the output work with the Dojo loader? Can either of you provide some details?

@clmath
Copy link
Member

clmath commented Jan 8, 2014

The biggest issue with the Dojo loader is that it does not process very well files with multiple define calls, which is a standard way to build an AMD application.

Indeed, if we have the following layer.js file:

define(A, [B], {});
define(B, [A], {});

the dojo loader will stop processing the file when it encounters the B dependency for module A and will try to load the module B from its own module file B.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants