Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-issue-1536 to support readonly root file system #88

Closed

Conversation

wangshu3000
Copy link

Purpose:
This PR is to resolve #85

Changes:

  1. Create 2 emptyDir volumes, for the /run and /tmp folder and mount them when the readOnlyRootFileSystem is set to true
  2. Update readme document
  3. Update values file default value

@callumpjackson
Copy link
Collaborator

@wangshu3000 Thanks for the pull request, could you please indicate that you accept and agree to be bound by the terms of the Developer's Certificate of Origin. We can then process this pull request.

@wangshu3000
Copy link
Author

Hi @callumpjacksons, Thanks for your reply.

As indicated by the Signed-off-by line, I'm attesting to the DCO.

Please proceed to process this pull request.

Thanks!

@wangshu3000
Copy link
Author

@callumpjackson Not sure if you got any time to review this PR. I have signed the DCO. Could you proceed to process this PR? Thanks.

@callumpjackson
Copy link
Collaborator

Sorry for the delay. Thanks for the above pull request. I've integrated the changes into #97. The reason for using this pull request instead of the original was due to merging with the 9.4.0 changes and the internal process we complete. Hope this works for yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance this helm chart to support readOnlyRootFileSystem settings on container security context
2 participants