Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ziomon: remove the packed attribute from structs #141

Open
sharkcz opened this issue Jul 20, 2022 · 1 comment
Open

ziomon: remove the packed attribute from structs #141

sharkcz opened this issue Jul 20, 2022 · 1 comment
Assignees
Labels

Comments

@sharkcz
Copy link
Contributor

sharkcz commented Jul 20, 2022

Seem the use of attribute((packed)) for ziomon's structs is not required for proper function of ziomon, see discussion in PR #137. Review and remove the attribute from the code.

@Benjamin-Block
Copy link
Member

@hoeppnerj probably better to assign this to @fedorloshakov, I'm just here to add my unqualified comments 😉

But may that as it be, like I said in slack, I see value in this; if nothing else it should reduce some technical debt in ziomon by get rid of unnecessary, and thus confusing, attributes; if they turn out to be unnecessary upon closer evaluation.

Can't make any promises in terms of time-frame though. This doesn't have a very high priority IMHO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants