Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revise valves and pump icons to indicate how they are controlled #1294

Closed
mwetter opened this issue Feb 21, 2020 · 4 comments · Fixed by #1302
Closed

revise valves and pump icons to indicate how they are controlled #1294

mwetter opened this issue Feb 21, 2020 · 4 comments · Fixed by #1302
Assignees

Comments

@mwetter
Copy link
Contributor

mwetter commented Feb 21, 2020

This issue is to implement different graphics to indicate if valves are open/closed and what speed the pumps are operating at. This addresses https://github.com/ibpsa/project1/wiki/2020-01-20-library-development#new-action-items

@mwetter mwetter self-assigned this Feb 21, 2020
mwetter added a commit that referenced this issue Feb 21, 2020
@mwetter
Copy link
Contributor Author

mwetter commented Feb 21, 2020

The development branch is issue1294_dynamicIcons.

I also tried to place another triangle over the input connector, but this won't be visible because the input connector is always on the top of the graphical elements.

mwetter added a commit that referenced this issue Feb 21, 2020
mwetter added a commit that referenced this issue Feb 21, 2020
@mwetter
Copy link
Contributor Author

mwetter commented Feb 29, 2020

Updates have been made to various icons (mixing volumes, sensors, delays, valves, pumps, pressure drop, etc.), see below.

image

I tried to display the most important quantities without overloading the graphics. The changes are only visible during/after the simulation, but not when building a model. In Dymola, move the slider under "Animation control" or slide the "Measurement cursor" in a plot to see the current values.

  • Valves show which port is open (white) or closed (black)
  • Pressure drops show with a black bar how big the flow is relative to m_flow_nominal. If the flow is negative, the bar is red.
  • Junctions also show how big the inflowing mass flow rate is (black) and how big the outflowing mass flow rate is (red).
  • Volumes and pressure sources show the temperature and change the color based on their temperature, although scaling was not that straightforward because of the large range in temperatures that we typically have.
  • Sensors show the measured quantity, and different number formatting is used depending on the expected range of the number.
  • The weather data reader displays the outside drybulb temperature.

More can be added in a next phase by copying the current annotations (so that uniform font sizes are used).

@Mathadon
Copy link
Member

looks fancy!

@mwetter
Copy link
Contributor Author

mwetter commented Mar 3, 2020

Michael to verify that y and not y_actual is consistently used, then make a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants