Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve PlugFlowPipe compatibility with PartialTwoPortInterface #1494

Closed
bravache opened this issue Jun 2, 2021 · 0 comments · Fixed by #1503
Closed

Resolve PlugFlowPipe compatibility with PartialTwoPortInterface #1494

bravache opened this issue Jun 2, 2021 · 0 comments · Fixed by #1503

Comments

@bravache
Copy link
Contributor

bravache commented Jun 2, 2021

Linked issue (with further discussion): lbl-srg/modelica-buildings#2449

Issue

The IBPSA.Fluid.FixedResistances.PlugFlowPipe model extends from PartialTwoPortVector, which uses a vectorized outlet port. This inheritance is at odds with the other pipe models in the FixedResistances packages, and prevents this model from being used to redeclare PartialTwoPortInterface objects.

Context

The model IBPSA.Fluid.FixedResistances.PlugFlowPipe is a wrapper for the IBPSA.Fluid.FixedResistances.BaseClasses.PlugFlowCore that incorporates a mixing volume vol and a vectorized outlet port ports_b[].
image

The mixing volume is used to model the heat capacity of the pipe walls and the outlet port is vectorized to prevent the need to add a splitter or mixing volume after the model when the outlet is branching out, therefore making the integration of the model more computationally efficient.

Proposed solution

The solution proposed is to deprecate the PlugFlowPipe model as it currently exist, and promote the BaseClasses.PlugFlowCore in its place. The mixing volume would either be integrated into the PlugFlowCore model, but connected to a non-vectorized port (similar to the implementation of Buildings.Fluid.FixedResistances.Pipe in MBL) or removed entirely (if we can validate that its impact on outputs are negligible in most use cases).

This solution would simplify the use of the plug flow model, and make its integration more explicit and clear (i.e. the model only represent a pipe, and not a pipe + mixing volume). This solution also remove the redundancy of having two models with similar usage, name and behavior (PlugFlowPipe and BaseClasses.PlugFlowCore).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant