Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile commands #365

Closed
dhblum opened this issue Oct 6, 2021 · 1 comment
Closed

Update Dockerfile commands #365

dhblum opened this issue Oct 6, 2021 · 1 comment

Comments

@dhblum
Copy link
Collaborator

dhblum commented Oct 6, 2021

This issue is to add the use of CMD python restapi.py && bash and EXPOSE 5000 in Dockerfile to encode this default behavior there instead of the makefile. Use of docker run -P will publish the container port 5000 (on which the api is listening) to a random host port, while continued use of docker run -p 127.0.0.1:5000:5000 is needed to publish specifically to port 127.0.0.1:5000 of the host. See https://docs.docker.com/engine/reference/builder/#expose.

@dhblum
Copy link
Collaborator Author

dhblum commented Jan 26, 2022

As described in #366, this issue also replaces the use of the makefile with docker-compose, which is good especially for Windows users to alleviate needing to install make or WSL and makes it easier to use native docker commands. The makefile is kept, however, and updated as needed to make make build and make run deprecated.

Note #366 closed this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant