Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a list of points to /results #398

Closed
dhblum opened this issue Jan 28, 2022 · 4 comments
Closed

Provide a list of points to /results #398

dhblum opened this issue Jan 28, 2022 · 4 comments
Milestone

Comments

@dhblum
Copy link
Collaborator

dhblum commented Jan 28, 2022

This issue is to suggest making the ability to provide a list of points to the /results API call, instead of requiring one at a time. The return would be the same object, just with additional arrays of point data.

While I acknowledge the potential memory issues of calling for large amounts of data (e.g. #240), this would reduce the need for excessive network requests (say in a long for-loop), which could otherwise bottleneck the system. And, the user would have control over the amount of data returned at one time if memory becomes too much an issue.

@dhblum
Copy link
Collaborator Author

dhblum commented Jan 28, 2022

We may also consider similarly for forecast data when addressing #356.

@dhblum dhblum mentioned this issue May 18, 2022
10 tasks
@dhblum dhblum added this to the v1.0.0 milestone Aug 5, 2022
@EttoreZ
Copy link
Contributor

EttoreZ commented Aug 24, 2022

@dhblum would you mind create the branch issue398_ListOfPointsResultsAPI so I can make a pull request? All the unit tests passed on bestest_air and bestest_hydronic. However, there are still a couple of things to check before the pull request is completely ready:

  • Check that python examples run correctly
  • Check that Juilia examples run correctly
  • Make changes for Javascript examples
  • Check comments and documentation

@dhblum
Copy link
Collaborator Author

dhblum commented Aug 24, 2022

Thanks @EttoreZ. Branch created here https://github.com/ibpsa/project1-boptest/tree/issue398_ListOfPointsResultsAPI. Make the PR and unit tests will check bullets 1 and 2. 3 shouldn't be too hard to add if I have to, and I can review comments/docs.

@dhblum
Copy link
Collaborator Author

dhblum commented Sep 6, 2022

Closed by #480.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants