New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Result submission allowed one /advance call late #546

Closed

dhblum opened this issue Jun 15, 2023 · 1 comment

Milestone

Collaborator

dhblum commented Jun 15, 2023

In testcase.py, the self.scenario_end is used to allow submission of results to the online dashboard. This flag is set to true at https://github.com/ibpsa/project1-boptest/blob/master/testcase.py#L360 upon a user's attempt to advance a simulation past the defined scenario time period. Instead, the flag should be set to true when the user reaches the end of the scenario time period, somewhere here https://github.com/ibpsa/project1-boptest/blob/master/testcase.py#L345, and not have to try another advance call. FYI @haraldwalnum.

The text was updated successfully, but these errors were encountered:

dhblum changed the title ~~Result submission allowed one /advance call later~~ Result submission allowed one /advance call late

dhblum added this to the v0.5.0 milestone

dhblum mentioned this issue

Issue546 sce flag #566

Merged

dhblum closed this as completed in

c3e0192

Collaborator Author

dhblum commented Aug 28, 2023

Closed by #566.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment