Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow Röntgen icon set #75

Closed
tyrasd opened this issue Nov 22, 2022 · 5 comments
Closed

allow Röntgen icon set #75

tyrasd opened this issue Nov 22, 2022 · 5 comments
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request
Milestone

Comments

@tyrasd
Copy link
Collaborator

tyrasd commented Nov 22, 2022

The Röntgen icon set includes some potentially quite useful icons for presets. For example:

Röntgen icons are licensed under a Creative Commons Attribution 4.0 International License.

@tyrasd tyrasd added documentation Improvements or additions to documentation enhancement New feature or request dependencies Pull requests that update a dependency file labels Nov 22, 2022
@tyrasd tyrasd added this to the v6 milestone Dec 9, 2022
@tyrasd tyrasd closed this as completed in e95521f Jan 20, 2023
@westnordost
Copy link

Err, where are the icons though? I didn't find them in the repo

@tyrasd
Copy link
Collaborator Author

tyrasd commented Jan 31, 2023

Yeah, it's unfortunately not quite straight forward. Here's what I did for iD (openstreetmap/iD@98e9a11): install map-machine, then run map-machine icons to generate the individual icons, then take the icons_by_id version of the resulting output.

Alternatively, you could rely on iD's bundled copy at https://github.com/openstreetmap/iD/tree/develop/svg/roentgen – I will manually keep them up to date until a better solution is found.

//cc @enzet: It would be superbly nice to have a separate versioned package of just the pure icons, in order to use them more easily outside of map-machine. Do you think something like that would be feasible?

@tordans
Copy link
Collaborator

tordans commented Jan 31, 2023

@tyrasd this reminds me of openstreetmap/id-tagging-schema#314. Maybe this is a good reason to improve the documentation about how the whole icon stuff works from a dev but also from a content/"tagging"-contributor perspective.

@westnordost
Copy link

Alternatively, you could rely on iD's bundled copy at https://github.com/openstreetmap/iD/tree/develop/svg/roentgen – I will manually keep them up to date until a better solution is found.

Thanks!

@tordans
Copy link
Collaborator

tordans commented Mar 17, 2023

FYI I created enzet/map-machine#149 to track the issues of having the icons more easily consumed. I think there was no issue, yet, and it sounds like that really should be easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants