Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--add-xinclude should use bib.ietf.org URLs for I-Ds #1008

Closed
1 task done
ajeanmahoney opened this issue Jun 16, 2023 · 2 comments · Fixed by #1166
Closed
1 task done

--add-xinclude should use bib.ietf.org URLs for I-Ds #1008

ajeanmahoney opened this issue Jun 16, 2023 · 2 comments · Fixed by #1166
Labels
enhancement New feature or request v2v3 Issues with v2v3 conversion

Comments

@ajeanmahoney
Copy link
Collaborator

Description

The --add-xinclude switch creates xi:includes for RFC and I-D reference entries. However, the xi:include URLs for RFCs use bib.ietf.org, while the URLs for I-Ds use datatracker.ietf.org:

        <xi:include href="https://bib.ietf.org/public/rfc/bibxml/reference.RFC.7788.xml"/>
        <xi:include href="https://datatracker.ietf.org/doc/bibxml3/draft-ietf-babel-source-specific.xml"/>

datatracker URLs were preferred when datatracker had better BibXML information. However, it appears that BibXML contents at datatracker and bib.ietf.org are now the same. If that is the case, then the xi:include URLs that xml2rfc creates for I-Ds should use bib.ietf.org.

Code of Conduct
@ajeanmahoney ajeanmahoney added the enhancement New feature or request label Jun 16, 2023
@ajeanmahoney
Copy link
Collaborator Author

It would be nice if the flag could update any datatracker URLs in existing xi:includes to use bib.ietf.org URLs.

@kesara kesara added the v2v3 Issues with v2v3 conversion label Sep 20, 2024
kesara added a commit to kesara/xml2rfc that referenced this issue Sep 20, 2024
@kesara
fix: Use bib.ietf.org for I-D xinclude references
f63f309 
Fixes ietf-tools#1008
This was referenced Sep 20, 2024
Merged
Open
@kesara
Copy link
Member

kesara commented Sep 23, 2024 •
edited
Loading

It would be nice if the flag could update any datatracker URLs in existing xi:includes to use bib.ietf.org URLs.

@ajeanmahoney, I created #1167 for that feature request since that is a separate feature.

kesara added a commit that referenced this issue Sep 23, 2024
@kesara
fix(v2v3): Use bib.ietf.org for I-D xinclude references (#1166)
f297f11 
* chore: Run yestests pre-changes

* fix: Use bib.ietf.org for I-D xinclude references

Fixes #1008

* chore: Run yestests post-changes

* test: Add --add-xinclude --draft-revisions test

* chore: Run yestests post-changes with --draft-revisions test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request v2v3 Issues with v2v3 conversion
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(v2v3): Use bib.ietf.org for I-D xinclude references kesara/xml2rfc
2 participants
@kesara @ajeanmahoney